[PATCH] D51868: [libcxx] Build and test fixes for Windows
Hamza Sood via Phabricator
reviews at reviews.llvm.org
Wed Sep 19 07:25:06 PDT 2018
hamzasood updated this revision to Diff 166124.
hamzasood added a comment.
Herald added a subscriber: christof.
I've added a fix for another related issue: the tests would fail to link if libc++ is built only as a DLL.
The auto-linking doesn't look for a dynamic library unless `_DLL` is defined (which I think is done by passing `/MD` to CL), but the test runner doesn't use CL-style commands. This could either be solved by either manually defining that macro or just disabling auto-linking. The test runner already configures the linker correctly so disabling auto-linking seemed like the simplest option.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 4415 bytes
Desc: not available
More information about the libcxx-commits