[PATCH] D51868: [libcxx] Build and test fixes for Windows

Marshall Clow via Phabricator reviews at reviews.llvm.org
Tue Sep 18 19:34:31 PDT 2018

mclow.lists added inline comments.

Comment at: test/support/verbose_assert.h:24
         : (IsStreamable<decltype(std::wcerr), Tp>::value ? 2 : -1))>
-struct SelectStream {
+struct SelectErrStream {
   static_assert(ST == -1, "specialization required for ST != -1");
Why the renaming here? 

What's the deal with sometimes using `clog` and sometimes `cerr`?
(I know, you didn't do this, but ???)

  rCXX libc++


More information about the libcxx-commits mailing list