[libc-commits] [PATCH] D105843: [libc] Add option to run specific tests

[Siva Chandra via Phabricator via libc-commits]

sivachandra added inline comments.


================
Comment at: libc/cmake/modules/LLVMLibCTestRules.cmake:77
     "SRCS;HDRS;DEPENDS;COMPILE_OPTIONS" # Multi-value arguments
+    "LIBC_UNITTEST_TEST_MAIN"
     ${ARGN}
----------------
May be name is it `NO_LIBC_UNITTEST_TEST_MAIN`.


================
Comment at: libc/cmake/modules/LLVMLibCTestRules.cmake:153
+  if(LIBC_UNITTEST_TEST_MAIN)
+    target_link_libraries(${fq_target_name} PRIVATE LibcUnitTest testfilter_test libc_test_utils)
+  else()
----------------
You should not add `testfileter_test` here. It will be its own binary.


================
Comment at: libc/test/utils/UnitTest/CMakeLists.txt:1
+add_libc_testsuite(libc_libctest_runtests_unittests)
+
----------------
The suite name should probably be `libc_unittest_tests`.


================
Comment at: libc/utils/UnitTest/CMakeLists.txt:16
+
+target_include_directories(LibcUnitTestMain PUBLIC LibcUnitTest ${LIBC_SOURCE_DIR})
+add_dependencies(LibcUnitTestMain LibcUnitTest libc.utils.CPP.standalone_cpp)
----------------
Can you actually add a target as an include directory?


================
Comment at: libc/utils/UnitTest/LibcTestMain.cpp:11
+
+#include <string>
+
----------------
Is this used in this file?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105843/new/

https://reviews.llvm.org/D105843