[libc-commits] [PATCH] D105843: [libc] Add option to run specific tests

[Caitlyn Cano via Phabricator via libc-commits]

caitlyncano marked 6 inline comments as done.
caitlyncano added inline comments.


================
Comment at: libc/utils/UnitTest/CMakeLists.txt:16
+
+target_include_directories(LibcUnitTestMain PUBLIC LibcUnitTest ${LIBC_SOURCE_DIR})
+add_dependencies(LibcUnitTestMain LibcUnitTest libc.utils.CPP.standalone_cpp)
----------------
sivachandra wrote:
> Can you actually add a target as an include directory?
It didn't cause any issues to take LibcUnitTest out and the documentation doesn't warn about any problems with it, so I'm just going to leave it out. Does ${LIBC_SOURCE_DIR} include it after line 7 is run?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105843/new/

https://reviews.llvm.org/D105843