[libc-commits] [PATCH] D105843: [libc] Add option to run specific tests

[Arthur Eubanks via Phabricator via libc-commits]

aeubanks added inline comments.


================
Comment at: libc/test/utils/UnitTest/testfilter_test.cpp:11
+
+const char *TestFilter;
+
----------------
this still isn't used right?


================
Comment at: libc/utils/UnitTest/LibcTestMain.cpp:12-15
+#include "utils/testutils/ExecuteFunction.h"
+#include <cassert>
+#include <iostream>
+#include <string>
----------------
caitlyncano wrote:
> aeubanks wrote:
> > ditto
> Just need to keep <string> to return NULL, but got rid of the unnecessary ones. Thanks!!
it seemed weird to me that <string> defined NULL, so I did a little research and apparently <cstddef> is actually what defines it, <string> probably just includes <cstddef>

but in any case, in C++ we should use nullptr over NULL, and we won't need to include either


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105843/new/

https://reviews.llvm.org/D105843