[libc-commits] [PATCH] D73337: Fix missing dependency in LibcUnitTest

[Guillaume Chatelet via Phabricator via libc-commits]

gchatelet added a comment.

In D73337#1840644 <https://reviews.llvm.org/D73337#1840644>, @sivachandra wrote:

> In D73337#1840618 <https://reviews.llvm.org/D73337#1840618>, @abrachet wrote:
>
> > I think this patch is still correct to add this, though. Even if the unittest itself will be linked to Support and also linked against LibcUnitTest and even if LibcUnitTest will never be used outside of that context, it would still make sense for LibcUnitTest to link against everything it needs. At worst this can't hurt.
>
>
> If you want to keep it here, then you should remove it from the list of the test exe's link libraries. I have verified that such a scheme works. So, with that change included, this change is alright with me.


So for completeness here was the reproducer

  cd llvm-project
  rm -rf /tmp/build
  cmake -B/tmp/build -Sllvm -DLLVM_ENABLE_PROJECTS=libc -DBUILD_SHARED_LIBS=ON -DCMAKE_BUILD_TYPE=Debug
  make -C /tmp/build -j

The error happens if you build everything.

I've updated the patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73337/new/

https://reviews.llvm.org/D73337