[libc-commits] [PATCH] D73337: Fix missing dependency in LibcUnitTest

Guillaume Chatelet via Phabricator via libc-commits libc-commits at lists.llvm.org
Sun Jan 26 03:17:15 PST 2020


gchatelet updated this revision to Diff 240427.
gchatelet added a comment.

- Address comments


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73337/new/

https://reviews.llvm.org/D73337

Files:
  libc/cmake/modules/LLVMLibCRules.cmake
  libc/utils/UnitTest/CMakeLists.txt


Index: libc/utils/UnitTest/CMakeLists.txt
===================================================================
--- libc/utils/UnitTest/CMakeLists.txt
+++ libc/utils/UnitTest/CMakeLists.txt
@@ -2,4 +2,5 @@
   LibcUnitTest
   Test.cpp
   Test.h
+  LINK_COMPONENTS Support
 )
Index: libc/cmake/modules/LLVMLibCRules.cmake
===================================================================
--- libc/cmake/modules/LLVMLibCRules.cmake
+++ libc/cmake/modules/LLVMLibCRules.cmake
@@ -356,7 +356,7 @@
     gtest
   )
 
-  target_link_libraries(${target_name} PRIVATE LibcUnitTest LLVMSupport)
+  target_link_libraries(${target_name} PRIVATE LibcUnitTest)
 
   add_custom_command(
     TARGET ${target_name}


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73337.240427.patch
Type: text/x-patch
Size: 698 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libc-commits/attachments/20200126/8ddab751/attachment-0001.bin>


More information about the libc-commits mailing list