[libc-commits] [PATCH] D73337: Fix missing dependency in LibcUnitTest

Sun Jan 26 11:12:42 PST 2020

abrachet accepted this revision.
abrachet added a comment.

LGTM, I would wait for Siva though.

In D73337#1840856 <https://reviews.llvm.org/D73337#1840856>, @gchatelet wrote:

> So for completeness here was the reproducer
>
>   cd llvm-project
>   rm -rf /tmp/build
>   cmake -B/tmp/build -Sllvm -DLLVM_ENABLE_PROJECTS=libc -DBUILD_SHARED_LIBS=ON -DCMAKE_BUILD_TYPE=Debug
>   make -C /tmp/build -j
>
>
> The error happens if you build everything.
>
> I've updated the patch.

A little bit off topic, can you successfully build with make? A few weeks ago when I tried cmake was producing invalid Makefiles but ninja was fine. It broke for Siva too https://reviews.llvm.org/D72353#1808817

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73337/new/

https://reviews.llvm.org/D73337