[flang-commits] [flang] [flang][mlir] Add flang to mlir lowering for groupprivate (PR #180934)

Sergio Afonso via flang-commits flang-commits at lists.llvm.org
Tue Jun 9 08:08:50 PDT 2026


================
@@ -99,6 +113,11 @@ class WithOmpDeclarative {
   // The argument to DEVICE_TYPE clause. Only needed when the clause is
   // present in the ompDeclTarget_ set.
   std::optional<common::OmpDeviceType> ompDeviceType_;
----------------
skatrak wrote:

Nit: We should disambiguate the names, rather than assuming `declare_target` is the default. Same with the associated getter.
```suggestion
  std::optional<common::OmpDeviceType> ompDeclTargetDeviceType_;
```

https://github.com/llvm/llvm-project/pull/180934


More information about the flang-commits mailing list