[flang-commits] [flang] [flang][mlir] Add flang to mlir lowering for groupprivate (PR #180934)

[Sergio Afonso via flang-commits]

================
@@ -4628,7 +4746,9 @@ static void genOMP(lower::AbstractConverter &converter, lower::SymMap &symTable,
                    semantics::SemanticsContext &semaCtx,
                    lower::pft::Evaluation &eval,
                    const parser::OmpGroupprivateDirective &directive) {
-  TODO(converter.getCurrentLocation(), "GROUPPRIVATE");
+  // The semantic analysis sets the flag and device_type on the
+  // symbols; omp.groupprivate is materialised on first use in a teams region
+  // by groupprivatizeVars.
----------------
skatrak wrote:

Nit: `groupprivate` is not something exclusive to `teams`, so I'd prefer to avoid direct references to that, so we can add a TODO comment for it in a single spot.
```suggestion
  // The semantic analysis sets the flag and device_type on the
  // symbols; omp.groupprivate is materialised by groupprivatizeVars.
```

https://github.com/llvm/llvm-project/pull/180934