[flang-commits] [flang] [Flang][MLIR] Teach AddAliasTags getFuncArgName to deal with omp::TargetOp's (PR #92036)

[via flang-commits]

agozillon wrote:

> The code changes look good to me, but I wonder if it is a good idea to run AddAliasTags on TargetOp and MapInfoOp.
> 
> The tbaa alias information was carefully thought out for normal fortran, but I haven't put much thought into whether it is valid for OpenMP. There is a known issue when inlining the same "function" multiple times into the same block: #89829, and generally we have to be careful about any sort of inlining.
> 
> If you have already thought about how the per-"function" alias trees interact with OpenMPIRBuilder then I think this is okay, but I would be hesitant if this is just a case of "make the pass pipeline work with my new operation".
> 
> I have some downstream work to generalize the alias tags pass to more operations, but I haven't gotten chance to work on it for a couple of weeks.
> 
> (apologies if I missed some patches that landed last week, I am not fully caught up yet after time off)

In this case I hadn't thought too much about the implications of adding the AddAliasTags pass on TargetOp's/MapInfoOp's, I had just assumed (likely incorrectly) that it would be a reasonable thing to do and was perhaps supposed to work already! 

But it seems that might not be the case, and would require further thought. Is there a possible fix that would exclude TargetOp's from this pass for the time being if that is a more prudent direction? Or any other recommended directions?

https://github.com/llvm/llvm-project/pull/92036