[flang-commits] [flang] [Flang][MLIR] Teach AddAliasTags getFuncArgName to deal with omp::TargetOp's (PR #92036)

[Tom Eccles via flang-commits]

tblah wrote:

Yes you were right to assume that this should work already. I should have got to this sooner.

I think `fir::AliasAnalysis::getSource` is wrong to say that these are dummy arguments. That is what is causing the TBAA tags pass to get confused. `getFuncArgName` should assert that `func` is non-null, and release builds should return `""` if it is not (so that we don't tag things that aren't dummy arguments as dummy arguments).

I think `isDummyArgument` (https://github.com/llvm/llvm-project/blob/main/flang/lib/Optimizer/Analysis/AliasAnalysis.cpp#L31) needs to check that the "entry block" has an immediate parent that implements `mlir::FunctionOpInterface`. I'll post a patch.

https://github.com/llvm/llvm-project/pull/92036