[flang-commits] [flang] [Flang][MLIR] Teach AddAliasTags getFuncArgName to deal with omp::TargetOp's (PR #92036)

[Tom Eccles via flang-commits]

https://github.com/tblah commented:

The code changes look good to me, but I wonder if it is a good idea to run AddAliasTags on TargetOp and MapInfoOp.

The tbaa alias information was carefully thought out for normal fortran, but I haven't put much thought into whether it is valid for OpenMP. There is a known issue when inlining the same "function" multiple times into the same block: https://github.com/llvm/llvm-project/issues/89829, and generally we have to be careful about any sort of inlining.

If you have already thought about how the per-"function" alias trees interact with OpenMPIRBuilder then I think this is okay, but I would be hesitant if this is just a case of "make the pass pipeline work with my new operation".

I have some downstream work to generalize the alias tags pass to more operations, but I haven't gotten chance to work on it for a couple of weeks. 

(apologies if I missed some patches that landed last week, I am not fully caught up yet after time off)

https://github.com/llvm/llvm-project/pull/92036