[flang-commits] [PATCH] D138150: [flang] Lower F08 NORM2 intrinsic

[Jean Perier via Phabricator via flang-commits]

jeanPerier added a comment.

In D138150#3954778 <https://reviews.llvm.org/D138150#3954778>, @tarunprabhu wrote:

> In D138150#3936115 <https://reviews.llvm.org/D138150#3936115>, @jeanPerier wrote:
>
>> I think we may want to change the runtime API here, otherwise your code looks good to me.
>
> The runtime implementations of Norm2 eventually use `DoTotalReduction` which needs a mask argument. We would need to provide an alternative to/overload of `DoTotalReduction` that does not require a mask.

Couldn't Norm2 runtime implementation just pass a nullptr mask to  `DoTotalReduction` instead ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138150/new/

https://reviews.llvm.org/D138150