[flang-commits] [PATCH] D138150: [flang] Lower F08 NORM2 intrinsic

[Jean Perier via Phabricator via flang-commits]

jeanPerier added a comment.

I think we may want to change the runtime API here, otherwise your code looks good to me.



================
Comment at: flang/lib/Lower/IntrinsicCall.cpp:3953-3954
+
+  // The runtime functions require a mask even though the intrinsic does not
+  // use it.
+  auto mask = builder.create<fir::AbsentOp>(
----------------
If the mask argument of the runtime is not needed for NORM2, I would rather prefer we remove it from the runtime signature if @klausler can confirm it had no purpose.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138150/new/

https://reviews.llvm.org/D138150