[flang-commits] [PATCH] D138140: [flang] Lower F08 FINDLOC intrinsic

[Tarun Prabhu via Phabricator via flang-commits]

tarunprabhu marked an inline comment as done.
tarunprabhu added inline comments.


================
Comment at: flang/runtime/reduction-templates.h:60
         if (IsLogicalElementTrue(*mask, maskAt)) {
-          accumulator.template AccumulateAt<TYPE>(xAt);
+          if (!accumulator.template AccumulateAt<TYPE>(xAt))
+            break;
----------------
clementval wrote:
> Is this change needed for findloc?
Yes. If the reduction is not short-circuited, only the last occurrence of the value is found. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D138140/new/

https://reviews.llvm.org/D138140