[flang-commits] [PATCH] D137204: [flang] Add check for constraints on event-stmts

[Pete Steinfeld via Phabricator via flang-commits]

PeteSteinfeld added a comment.

Things generally look good, and everything builds and tests correctly.  But if there's no problem moving the query functions to the Semantics directory, we should do that.



================
Comment at: flang/include/flang/Evaluate/tools.h:1202-1203
 bool IsBuiltinCPtr(const Symbol &);
+bool IsEventType(const DerivedTypeSpec *);
+bool IsLockType(const DerivedTypeSpec *);
 // Is this derived type TEAM_TYPE from module ISO_FORTRAN_ENV?
----------------
Is Evaluate/tools.h the right place for these functions?

Note that the function `IsOrContainsEventOrLockComponent()` is in Semantics/tools.h.  It also looks like all references to these functions come from within the Semantics directory.  Putting them all in the same files and directory makes more sense to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137204/new/

https://reviews.llvm.org/D137204