[flang-commits] [PATCH] D140288: [flang] Do not convey captured globals through host link

[Jean Perier via Phabricator via flang-commits]

jeanPerier added inline comments.


================
Comment at: flang/include/flang/Lower/HostAssociations.h:35-37
+  /// Returns true iff there are no host associations that are conveyed through
+  /// an extra tuple argument.
+  bool hasTupleAssociations() const { return tupleSymbols.empty(); }
----------------
PeteSteinfeld wrote:
> This doesn't seem right.  `hasTupleAssociations()` returns true when there are no tuple symbols?  Should this be called `hasNoTupleAssociations()`?
Woops, of course, thanks ! I will actually keep the name and reverse the logic since its only use is negating it (so that I can remove the negation).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140288/new/

https://reviews.llvm.org/D140288