[flang-commits] [PATCH] D140288: [flang] Do not convey captured globals through host link

[Pete Steinfeld via Phabricator via flang-commits]

PeteSteinfeld accepted this revision.
PeteSteinfeld added a comment.
This revision is now accepted and ready to land.

Aside from the name of `hasTupleAssociations()`, all builds and tests correctly and looks good.



================
Comment at: flang/include/flang/Lower/HostAssociations.h:35-37
+  /// Returns true iff there are no host associations that are conveyed through
+  /// an extra tuple argument.
+  bool hasTupleAssociations() const { return tupleSymbols.empty(); }
----------------
This doesn't seem right.  `hasTupleAssociations()` returns true when there are no tuple symbols?  Should this be called `hasNoTupleAssociations()`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140288/new/

https://reviews.llvm.org/D140288