[flang-commits] [PATCH] D91209: [flang] Fix CheckSpecificationExpr handling of associated names

[Peter Klausler via Phabricator via flang-commits]

klausler added a comment.

In D91209#2389115 <https://reviews.llvm.org/D91209#2389115>, @awarzynski wrote:

> I think that the root cause of the build failure is the circular dependency: `FortranSemantics <-> FortranEvaluate <-> FortranSemantics`.  Adding `inline` to `IsModule` and `IsSubmodule` fixes this particular build issue, but not the circular dependency.

We know.  The long-term solution seems to be to refactor the representational aspects of Semantics -- i.e., scopes and symbols -- into their own library, but that's a big job that nobody has time for.  For now, we restrict Evaluate to depend on the headers of Semantics but not its binary library.  (The other solution would be to combine Evaluate back into Semantics, of course.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91209/new/

https://reviews.llvm.org/D91209