[flang-commits] [PATCH] D91210: [flang][MSVC] Use list<Message> rather than forward_list<> in Messages

[Peter Klausler via Phabricator via flang-commits]

klausler created this revision.
klausler added a reviewer: Meinersbur.
klausler added a project: Flang.
Herald added subscribers: llvm-commits, jdoerfert.
Herald added a project: LLVM.
klausler requested review of this revision.

The implementation of Messages with forward_list<> makes some
nonstandard assumptions about the validity of iterators that don't
hold up with MSVC's implementation.  Use list<> instead.  The
measured performance is comparable.

This change obviated a distinction between two member functions
of Messages, and the uses of one have been replaced with calls
to the other.

Similar usage in CharBuffer was also replaced for consistency.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D91210

Files:
  flang/include/flang/Parser/char-buffer.h
  flang/include/flang/Parser/instrumented-parser.h
  flang/include/flang/Parser/message.h
  flang/lib/Parser/basic-parsers.h
  flang/lib/Parser/char-buffer.cpp
  flang/lib/Parser/message.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D91210.304332.patch
Type: text/x-patch
Size: 6617 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/flang-commits/attachments/20201110/5b93e4e0/attachment.bin>