[flang-commits] [PATCH] D79851: [Flang] Semantics for SELECT TYPE

[sameeran joshi via Phabricator via flang-commits]

sameeranjoshi added inline comments.


================
Comment at: flang/lib/Semantics/check-select-type.cpp:93-94
+              if (const DeclTypeSpec * spec{typeSpec.declTypeSpec}) {
+                if (spec->category() == DeclTypeSpec::Character &&
+                    !guardDynamicType.IsAssumedLengthCharacter()) { // C1160
+                  context_.Say(parser::FindSourceLocation(typeSpec),
----------------
PeteSteinfeld wrote:
> C1160 applies to LEN type parameters for both character and derived types.  It doesn't look like you're checking or testing for LEN parameters on derived types.  Can you please add a check and test?
Do you mean a test like below?
   type :: t(n)
      integer, len :: n
   end type

And inside `SELECT TYPE` something like :
 type is ( t(n=*) )   !<-- assumed length-type


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79851/new/

https://reviews.llvm.org/D79851