[flang-commits] [PATCH] D79851: [Flang] Semantics for SELECT TYPE

[sameeran joshi via Phabricator via flang-commits]

sameeranjoshi added inline comments.


================
Comment at: flang/lib/Semantics/resolve-names.cpp:5101-5102
+
+    } else if (evaluate::HasVectorSubscript(
+                   *association.selector.expr)) { // C1158
+      Say(association.selector.source,
----------------
PeteSteinfeld wrote:
> C1158 also applies to selectors that are not variables.  Can you please add a check and test for that situation?
I was confused from the wordings of standard.
This is what I understand,
If selector is not a variable => throw respective error
if selector is a variable that has a vector subscript -> throw error

Is this what you meant, that I am missing the first check?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79851/new/

https://reviews.llvm.org/D79851