[flang-commits] [PATCH] D79347: [flang] Handle EQUIVALENCE and COMMON in size and offset computations

Tim Keith via Phabricator via flang-commits flang-commits at lists.llvm.org
Wed May 6 11:52:48 PDT 2020


tskeith added inline comments.


================
Comment at: flang/include/flang/Semantics/symbol.h:306
   void set_bindName(MaybeExpr &&expr) { bindName_ = std::move(expr); }
+  std::size_t align() const { return align_; }
+  void set_align(std::size_t align) { align_ = align; }
----------------
tskeith wrote:
> sscalpone wrote:
> > align is a verb, and someone might think this call is aligning something.  how about g/align/s//alignment/?
> Scope and ComputeOffsetsHelper already have data members named `align_`. Do you want those changed too?
I'll do the renaming in a separate change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79347/new/

https://reviews.llvm.org/D79347





More information about the flang-commits mailing list