[flang-commits] [PATCH] D79347: [flang] Handle EQUIVALENCE and COMMON in size and offset computations

[Tim Keith via Phabricator via flang-commits]

tskeith added inline comments.


================
Comment at: flang/include/flang/Semantics/symbol.h:306
   void set_bindName(MaybeExpr &&expr) { bindName_ = std::move(expr); }
+  std::size_t align() const { return align_; }
+  void set_align(std::size_t align) { align_ = align; }
----------------
sscalpone wrote:
> align is a verb, and someone might think this call is aligning something.  how about g/align/s//alignment/?
Scope and ComputeOffsetsHelper already have data members named `align_`. Do you want those changed too?


================
Comment at: flang/lib/Semantics/compute-offsets.cpp:74
 
+static bool InCommonBlock(const Symbol &symbol) {
+  const auto *details{symbol.detailsIf<ObjectEntityDetails>()};
----------------
sscalpone wrote:
> InCommonBlock might be helpful for lowering, but i'm just guessing, because i'm not doing any lowering.
Me neither. I think it should be made public if and when it is needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79347/new/

https://reviews.llvm.org/D79347