[cfe-dev] RFC: Easier AST Matching by Default

Yitzhak Mandelbaum via cfe-dev cfe-dev at lists.llvm.org
Wed May 27 08:33:48 PDT 2020

Stephen -- there are three upstream changes that we'll need to fix all of
our tests:
1. Transformers' `applyFirst`, as discussed in the thread on D80606.
2. Add an overload of the `traverse` matcher for `DynTypedMatcher`.
3. Support `traverse` in the matcher parser (the one used by clang-query).

I'm working on the first one now. But, do you have any thoughts/plans for
the latter two?


On Wed, May 27, 2020 at 10:31 AM Sam McCall <sammccall at google.com> wrote:

> On Wed, May 27, 2020 at 4:15 PM Stephen Kelly <steveire at gmail.com> wrote:
>> On Wed 27 May 2020, 13:38 Stephen Kelly, <steveire at gmail.com> wrote:
>>> I will be away now for a few hours. I'll look more into the bug
>>> discovered via the transform library when I return.
>> I also want to say that I'm fine with reverting this latch temporarily to
>> make time for adjustment to be made in your codebase.
>> I have a follow up patch ready to commit after the change of default, but
>> I deliberately didn't commit it yet because I expected there might be an
>> issue like this - motivated externally and which I couldn't predict -
>> requiring the change of default to be temporarily reverted.
> That's much appreciated (I was concerned we might need to revert ASAP if
> at all, because of dependent changes).
> Looks like there's no need on Google's account (not sure if other orgs are
> struggling with this) - we've managed to pull in the change.
> (There's still a chance we find out there's some other surprising
> breakage, but looks good so far)
>> I knew that the RFC and email thread inevitably wouldn't get some of the
>> needed attention until the change drew attention to itself :).
> Haha, no kidding. Sorry about that...
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20200527/663b7f86/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 3854 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20200527/663b7f86/attachment.bin>

More information about the cfe-dev mailing list