<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Stephen -- there are three upstream changes that we'll need to fix all of our tests:</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">1. Transformers' `applyFirst`, as discussed in the thread on D80606. </div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">2. Add an overload of the `traverse` matcher for `DynTypedMatcher`.</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">3. Support `traverse` in the matcher parser (the one used by clang-query).</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">I'm working on the first one now. But, do you have any thoughts/plans for the latter two?</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif">Thanks!</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, May 27, 2020 at 10:31 AM Sam McCall <<a href="mailto:sammccall@google.com">sammccall@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr">On Wed, May 27, 2020 at 4:15 PM Stephen Kelly <<a href="mailto:steveire@gmail.com" target="_blank">steveire@gmail.com</a>> wrote:</div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto"><div class="gmail_quote" dir="auto"><div dir="ltr" class="gmail_attr">On Wed 27 May 2020, 13:38 Stephen Kelly, <<a href="mailto:steveire@gmail.com" target="_blank">steveire@gmail.com</a>> wrote: </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div bgcolor="#FFFFFF">
<p>I will be away now for a few hours. I'll look more into the bug
discovered via the transform library when I return.</p></div></blockquote></div><div dir="auto"><br></div><div dir="auto">I also want to say that I'm fine with reverting this latch temporarily to make time for adjustment to be made in your codebase.</div><div dir="auto"><br></div><div dir="auto">I have a follow up patch ready to commit after the change of default, but I deliberately didn't commit it yet because I expected there might be an issue like this - motivated externally and which I couldn't predict - requiring the change of default to be temporarily reverted. </div></div></blockquote><div>That's much appreciated (I was concerned we might need to revert ASAP if at all, because of dependent changes).</div><div>Looks like there's no need on Google's account (not sure if other orgs are struggling with this) - we've managed to pull in the change.</div><div>(There's still a chance we find out there's some other surprising breakage, but looks good so far)</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto"><div dir="auto">I knew that the RFC and email thread inevitably wouldn't get some of the needed attention until the change drew attention to itself :). </div></div></blockquote><div>Haha, no kidding. Sorry about that...</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto"><div class="gmail_quote" dir="auto"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div bgcolor="#FFFFFF">
<div dir="auto">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
</blockquote>
</div>
</div>
</div>
</blockquote></div></div>
</blockquote></div></div>
</blockquote></div>