[cfe-dev] [Preprocessor] MSVC Preprocessor compatibility fixes

[Nico Weber via cfe-dev]

On Thu, Apr 13, 2017 at 5:41 PM, Keane, Erich <erich.keane at intel.com> wrote:

> Responses inline, sorry for the goofy formatting, using Outlook.
>
>
>
> *From:* thakis at google.com [mailto:thakis at google.com] *On Behalf Of *Nico
> Weber
> *Sent:* Thursday, April 13, 2017 2:36 PM
> *To:* Keane, Erich <erich.keane at intel.com>
> *Cc:* cfe-dev at lists.llvm.org
> *Subject:* Re: [cfe-dev] [Preprocessor] MSVC Preprocessor compatibility
> fixes
>
>
>
> General comments:
>
> * Are these necessary for parsing system headers?
>
> *[Keane, Erich] No, these are all based on our internal test suite,
> usually because they were used in some sort of open source project.*
>

Is it possible to fix the project instead?


> *  Our “Windows Dashboard” has a pretty poor compilation success rate, of
> which these seem to matter quite a bit. *
>
> * Is it possible to emit some -Wmicrosoft warning for when we do these? (
> https://docs.google.com/presentation/d/1oxNHaVjA9Gn_rTzX6HIpJHP7nXRua_
> 0URXxxJ3oYRq0/edit#slide=id.g71ecd450e_2_812)
>
> *[Keane, Erich] Possible?  Sure.  I didn’t see any existing warning for
> this case in the current __VA_ARGS__ situation, but if consensus is that we
> should do so, I can definitely add that.*
>
>
>
>
>
> On Thu, Apr 13, 2017 at 5:21 PM, Keane, Erich via cfe-dev <
> cfe-dev at lists.llvm.org> wrote:
>
> Hi all, I've prepared a number of fixes to the preprocessor in the name of
> MSVC compatibility!
>
> https://reviews.llvm.org/D32046
> https://reviews.llvm.org/D32049
> https://reviews.llvm.org/D32050
> https://reviews.llvm.org/D32051
> https://reviews.llvm.org/D32052
>
> Since Richard Smith is the only one who has any chance of being the code
> owner here, and because Reid is our MSVC compatibility Czar, I added them
> to the review.  However, if anyone knows of anyone with sufficient
> knowledge of the preprocessor, I'd appreciate it if you could add them to
> the review as well!
>
> Thanks all,
> Erich
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20170413/4466f4e6/attachment.html>