<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Thu, Apr 13, 2017 at 5:41 PM, Keane, Erich <span dir="ltr"><<a href="mailto:erich.keane@intel.com" target="_blank">erich.keane@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple">
<div class="m_6873278206505150830WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d">Responses inline, sorry for the goofy formatting, using Outlook.<u></u><u></u></span></p>
<p class="MsoNormal"><a name="m_6873278206505150830__MailEndCompose"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"><u></u> <u></u></span></a></p>
<p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> <a href="mailto:thakis@google.com" target="_blank">thakis@google.com</a> [mailto:<a href="mailto:thakis@google.com" target="_blank">thakis@google.com</a>]
<b>On Behalf Of </b>Nico Weber<br>
<b>Sent:</b> Thursday, April 13, 2017 2:36 PM<br>
<b>To:</b> Keane, Erich <<a href="mailto:erich.keane@intel.com" target="_blank">erich.keane@intel.com</a>><br>
<b>Cc:</b> <a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a><br>
<b>Subject:</b> Re: [cfe-dev] [Preprocessor] MSVC Preprocessor compatibility fixes<u></u><u></u></span></p>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">General comments:<u></u><u></u></p>
<div><span class="">
<p class="MsoNormal">* Are these necessary for parsing system headers?<u></u><u></u></p>
</span><p class="MsoNormal"><b><i><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d">[Keane, Erich] No, these are all based on our internal test suite, usually because they were used in some sort of open source project.</span></i></b></p></div></div></div></div></blockquote><div><br></div><div>Is it possible to fix the project instead?</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div lang="EN-US" link="blue" vlink="purple"><div class="m_6873278206505150830WordSection1"><div><div><p class="MsoNormal"><b><i><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"> Our “Windows Dashboard”
has a pretty poor compilation success rate, of which these seem to matter quite a bit.
</span></i></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"><u></u><u></u></span></p>
</div>
<div><span class="">
<p class="MsoNormal">* Is it possible to emit some -Wmicrosoft warning for when we do these? (<a href="https://docs.google.com/presentation/d/1oxNHaVjA9Gn_rTzX6HIpJHP7nXRua_0URXxxJ3oYRq0/edit#slide=id.g71ecd450e_2_812" target="_blank">https://docs.google.com/<wbr>presentation/d/1oxNHaVjA9Gn_<wbr>rTzX6HIpJHP7nXRua_<wbr>0URXxxJ3oYRq0/edit#slide=id.<wbr>g71ecd450e_2_812</a>)<u></u><u></u></p>
</span><p class="MsoNormal"><b><i><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d">[Keane, Erich] Possible? Sure. I didn’t see any existing warning for this case in the current __VA_ARGS__ situation, but if consensus is that we should
do so, I can definitely add that.<u></u><u></u></span></i></b></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"><u></u> <u></u></span></p>
</div>
</div><span class="">
<div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">On Thu, Apr 13, 2017 at 5:21 PM, Keane, Erich via cfe-dev <<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a>> wrote:<u></u><u></u></p>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal">Hi all, I've prepared a number of fixes to the preprocessor in the name of MSVC compatibility!<br>
<br>
<a href="https://reviews.llvm.org/D32046" target="_blank">https://reviews.llvm.org/<wbr>D32046</a><br>
<a href="https://reviews.llvm.org/D32049" target="_blank">https://reviews.llvm.org/<wbr>D32049</a><br>
<a href="https://reviews.llvm.org/D32050" target="_blank">https://reviews.llvm.org/<wbr>D32050</a><br>
<a href="https://reviews.llvm.org/D32051" target="_blank">https://reviews.llvm.org/<wbr>D32051</a><br>
<a href="https://reviews.llvm.org/D32052" target="_blank">https://reviews.llvm.org/<wbr>D32052</a><br>
<br>
Since Richard Smith is the only one who has any chance of being the code owner here, and because Reid is our MSVC compatibility Czar, I added them to the review. However, if anyone knows of anyone with sufficient knowledge of the preprocessor, I'd appreciate
it if you could add them to the review as well!<br>
<br>
Thanks all,<br>
Erich<br>
______________________________<wbr>_________________<br>
cfe-dev mailing list<br>
<a href="mailto:cfe-dev@lists.llvm.org" target="_blank">cfe-dev@lists.llvm.org</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev" target="_blank">http://lists.llvm.org/cgi-bin/<wbr>mailman/listinfo/cfe-dev</a><u></u><u></u></p>
</blockquote>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</span></div>
</div>
</blockquote></div><br></div></div>