[cfe-dev] OMP4 Target Declare parse/sema patch

["C. Bergström"]

On 07/ 9/14 01:16 AM, Richard Smith wrote:
> It's hard to be sure this is correct since (unless I'm misreading) 
> this code would all be dead right now, since we don't yet support 
> parsing this directive.
>
> I'd like to see parsing support and testcases before I'd consider this 
> ready to commit. I'm also a bit concerned that (from a skim of the 
> OpenMP documentation) this seems to be an attribute that can be 
> applied to functions and variables, and not a statement, so modeling 
> it as an OMPExecutableDirective might be incorrect.
>
>
> +case OMPD_declare_update: {
>
> This line is underindented.
Intel already implemented this and I was too quick to hit send. 
Apologies for the duplicate effort and hopefully this feedback at the 
very least helps them (or others) in contributing more of their code.

Thanks Richard