[cfe-dev] OMP4 Target Declare parse/sema patch

[Richard Smith]

It's hard to be sure this is correct since (unless I'm misreading) this
code would all be dead right now, since we don't yet support parsing this
directive.

I'd like to see parsing support and testcases before I'd consider this
ready to commit. I'm also a bit concerned that (from a skim of the OpenMP
documentation) this seems to be an attribute that can be applied to
functions and variables, and not a statement, so modeling it as an
OMPExecutableDirective might be incorrect.


+case OMPD_declare_update: {

This line is underindented.

On Tue, Jul 1, 2014 at 9:19 AM, "C. Bergström" <cbergstrom at pathscale.com>
wrote:

> Hi
>
> Trivial patch which implements OMP4 target declare. Can someone please
> review and push if is acceptable or let me know what needs fixing.
>
> @Intel - I see you guys are missing it as well.. hopefully it helps save
> you a few minutes.
>
> Thanks
>
>
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20140708/7e74de55/attachment.html>