[cfe-dev] Problem parsing a simple C++ file.

[Manuel Klimek]

On Mon, Dec 3, 2012 at 8:23 AM, Sean Silva <silvas at purdue.edu> wrote:

> >
> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Tooling/Tooling.cpp?view=markup
>
> Ugh. Why is this directly including system headers? That's a blatant
> violation of <
> http://llvm.org/docs/SystemLibrary.html#don-t-include-system-headers>.
>
> Manuel, what kind of review did this code get before being checked in?
> I can't seem to find any review thread leading up to r154008.
>

http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20120123/051828.html
(note that this review went over 4 months, so the mail archive can't follow
it through; use site:lists.cs.uiuc.edu "[PATCH] Implements support to run
standalone tools" in your favorite search engine to find all parts of the
review)

Note also that the lines you object to are not in the original patch. The
patch that made those includes necessary was reviewed here:
http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20120507/057330.html
(again, the mail archive doesn't tell the full story)

If you have a better solution, feel free to make suggestions.

Cheers,
/Manuel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20121203/3f512014/attachment.html>