[cfe-dev] Problem parsing a simple C++ file.

Sean Silva silvas at purdue.edu
Sun Dec 2 23:23:28 PST 2012


> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Tooling/Tooling.cpp?view=markup

Ugh. Why is this directly including system headers? That's a blatant
violation of <http://llvm.org/docs/SystemLibrary.html#don-t-include-system-headers>.

Manuel, what kind of review did this code get before being checked in?
I can't seem to find any review thread leading up to r154008.

-- Sean Silva



More information about the cfe-dev mailing list