<div style="font-family: arial, helvetica, sans-serif; font-size: 10pt"><div>On Mon, Dec 3, 2012 at 8:23 AM, Sean Silva <span dir="ltr"><<a href="mailto:silvas@purdue.edu" target="_blank">silvas@purdue.edu</a>></span> wrote:<br>
</div><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">> <a href="http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Tooling/Tooling.cpp?view=markup" target="_blank">http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Tooling/Tooling.cpp?view=markup</a><br>

<br>
Ugh. Why is this directly including system headers? That's a blatant<br>
violation of <<a href="http://llvm.org/docs/SystemLibrary.html#don-t-include-system-headers" target="_blank">http://llvm.org/docs/SystemLibrary.html#don-t-include-system-headers</a>>.<br>
<br>
Manuel, what kind of review did this code get before being checked in?<br>
I can't seem to find any review thread leading up to r154008.<br></blockquote><div><br></div><div><a href="http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20120123/051828.html">http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20120123/051828.html</a><br>
</div><div>(note that this review went over 4 months, so the mail archive can't follow it through; use site:<a href="http://lists.cs.uiuc.edu">lists.cs.uiuc.edu</a> "[PATCH] Implements support to run standalone tools" in your favorite search engine to find all parts of the review)</div>
<div><br></div><div>Note also that the lines you object to are not in the original patch. The patch that made those includes necessary was reviewed here:</div><div><a href="http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20120507/057330.html">http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20120507/057330.html</a></div>
<div>(again, the mail archive doesn't tell the full story)</div><div><br></div><div>If you have a better solution, feel free to make suggestions.</div><div><br></div><div>Cheers,</div><div>/Manuel</div></div></div></div>