[cfe-dev] CodeGenModule::GetAddrOfConstantString(const StringLiteral *Literal)

[jahanian]

On Mar 23, 2011, at 3:47 AM, David Chisnall wrote:

> Hello the list,
> 
> Is there a reason why this function exists?
> 
> CodeGenModule::GetAddrOfConstantString(const StringLiteral *Literal);

Yes, it belongs to CGObjCMac.cpp. But in practice, it calls on routines local to CodeGenModule.cpp, which makes it more than
a move across refactoring.

- Fariborz

> 
> Aside from the confusing and misleading name (it emits an Objective-C string, in case you couldn't guess that from the name), it seems to be a layering violation since it's in CodeGenModule but implements behaviour specific to the Mac Objective-C runtimes (and isn't actually called anywhere outside CGObjCMac.cpp).
> 
> David
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev