[cfe-dev] CodeGenModule::GetAddrOfConstantString(const StringLiteral *Literal)

John McCall rjmccall at apple.com
Wed Mar 23 14:05:26 PDT 2011


On Mar 23, 2011, at 3:47 AM, David Chisnall wrote:
> Is there a reason why this function exists?
> 
> CodeGenModule::GetAddrOfConstantString(const StringLiteral *Literal);
> 
> Aside from the confusing and misleading name (it emits an Objective-C string, in case you couldn't guess that from the name), it seems to be a layering violation since it's in CodeGenModule but implements behaviour specific to the Mac Objective-C runtimes (and isn't actually called anywhere outside CGObjCMac.cpp).

Definitely seems like something to move to CGObjCMac.cpp.

John.



More information about the cfe-dev mailing list