[cfe-dev] Circumventing ExecuteAction's initialization of SourceManager instance

[Garrison Venn]

That would be a nice simplification, although I did not look at the results of the patch
just the patch file. I went git about a month ago for a non LLVM project, so I think 
when I have time I'll use your patch in a git version. Although I know that svn can work
with git, and people have publicly available git repos, I've been nervous about 
mixing the two. I guess there are no issues when submitting patches?

Garrison

On Nov 10, 2010, at 11:08, Peter Collingbourne wrote:

> On Wed, Nov 10, 2010 at 06:35:37AM -0500, Garrison Venn wrote:
>> FYI, in trunk it looks like they got rid of CompilerInvocation::setLangDefaults, and
>> replaced your usage with:
>> 
>> (CI->getLangOpts()).OpenCL = 1;
> 
> Hi Garrison,
> 
> Actually, setting OpenCL to 1 won't work on its own; there are a number
> of other flags that need to be set.  setLangDefaults is part of a patch
> [1] I sent to cfe-commits which is meant to make this use case easier
> to handle.  I'm still waiting for feedback on the patch (hint...)
> 
> Thanks,
> -- 
> Peter
> 
> [1] http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20101025/035808.html