[cfe-dev] Fix to the exception specifications type checking

[Douglas Gregor]

On Dec 10, 2009, at 8:42 AM, Nicola Gigante wrote:

> 
> Il giorno 10/dic/2009, alle ore 02.28, Douglas Gregor ha scritto:
> 
>> 
>> A couple comments:
>> 
>> +  // This check deals with core issue 437, when we have a member function of a
>> +  // class that throws the class itself.
>> 
>> It's nice to quote the actual standard text, so we don't have to refer to some other document when reading through this code, like below:
>> 
> Ok, I've quoted the standard in the comment now.
> 
>> 
>> Please uses spaces only (no tabs). 
> Yes, sorry again, I think there are only spaces now.
> 
>> 
>> There's another call to RequireCompleteType later in the function; you'll need to do a similar check there for pointers  or references to classes that are being defined.
> 
> Yes, I think a testcase is needed for that code path, too, so I've added it.
> 
> I think everything's ok now.

Thanks! Committed here:

	http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20091207/025199.html

	- Doug