[cfe-dev] Fix to the exception specifications type checking

[Nicola Gigante]

Il giorno 10/dic/2009, alle ore 02.28, Douglas Gregor ha scritto:

> 
> A couple comments:
> 
> +  // This check deals with core issue 437, when we have a member function of a
> +  // class that throws the class itself.
> 
> It's nice to quote the actual standard text, so we don't have to refer to some other document when reading through this code, like below:
> 
Ok, I've quoted the standard in the comment now.

> 
> Please uses spaces only (no tabs). 
Yes, sorry again, I think there are only spaces now.

> 
> There's another call to RequireCompleteType later in the function; you'll need to do a similar check there for pointers  or references to classes that are being defined.

Yes, I think a testcase is needed for that code path, too, so I've added it.

I think everything's ok now.

Thank you,

Nicola

-------------- next part --------------
A non-text attachment was scrubbed...
Name: issue-437.patch
Type: application/octet-stream
Size: 2450 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20091210/1b39f9ef/attachment.obj>