[clang] [llvm] [clang] Fix encoding handling of asm strings (PR #169803)
Hubert Tong via cfe-commits
cfe-commits at lists.llvm.org
Thu Nov 12 21:00:55 PST 2026
================
@@ -1391,8 +1391,22 @@ StringLiteral::getLocationOfByte(unsigned ByteNo, const SourceManager &SM,
unsigned TokNumBytes = SLP.GetStringLength();
// If the byte is in this token, return the location of the byte.
- if (ByteNo < TokNumBytes ||
- (ByteNo == TokNumBytes && TokNo == getNumConcatenated() - 1)) {
+ //
+ // The string data may have been converted to a different encoding (e.g.
+ // -fexec-charset) than the one obtained by re-lexing the source token here,
+ // so ByteNo can lie beyond the end of the last token. In that case, clamp
+ // to the end of the last token rather than failing.
+ //
+ // FIXME: When the conversion changes the number of bytes (e.g. a
+ // multi-byte UTF-8 sequence that maps to a single byte), ByteNo no longer
+ // corresponds to the byte offset in the source spelling, so the returned
----------------
hubert-reinterpretcast wrote:
... and similarly for the z/OS asm string case.
#### Source (`<stdin>`):
```c
void f(unsigned x) {
__asm__("\tXR %[\x68\x68],%[z]\n"
: [\u{c7}\u{c7}] "=r"(x));
}
```
#### Compiler invocation:
```
clang -fsyntax-only --target=s390x-ibm-zos -xc -
```
#### Output:
```
<stdin>:2:33: error: unknown symbolic operand name in inline assembly string
2 | __asm__("\tXR %[\x68\x68],%[z]\n"
| ~~~~~~~~~~~~~~~~~~~~~~^~~
1 error generated.
```
https://github.com/llvm/llvm-project/pull/169803
More information about the cfe-commits
mailing list