[clang] [llvm] [clang] Fix encoding handling of asm strings (PR #169803)
Hubert Tong via cfe-commits
cfe-commits at lists.llvm.org
Thu Nov 12 20:55:06 PST 2026
================
@@ -1391,8 +1391,22 @@ StringLiteral::getLocationOfByte(unsigned ByteNo, const SourceManager &SM,
unsigned TokNumBytes = SLP.GetStringLength();
// If the byte is in this token, return the location of the byte.
- if (ByteNo < TokNumBytes ||
- (ByteNo == TokNumBytes && TokNo == getNumConcatenated() - 1)) {
+ //
+ // The string data may have been converted to a different encoding (e.g.
+ // -fexec-charset) than the one obtained by re-lexing the source token here,
+ // so ByteNo can lie beyond the end of the last token. In that case, clamp
+ // to the end of the last token rather than failing.
+ //
+ // FIXME: When the conversion changes the number of bytes (e.g. a
+ // multi-byte UTF-8 sequence that maps to a single byte), ByteNo no longer
+ // corresponds to the byte offset in the source spelling, so the returned
----------------
hubert-reinterpretcast wrote:
For info, here is a reproducer for the `-fexec-charset` diagnostic-location issue that does not hit the assertion failure.
#### Source (`<stdin>`):
```c
int printf(const char *, ...);
int main(void) {
printf("©©%s");
}
```
#### Compiler invocation:
```
clang -cc1 -fsyntax-only -fexec-charset ISO-8859-1 -xc -
```
#### Output:
```
<stdin>:3:14: warning: more '%' conversions than data arguments [-Wformat-insufficient-args]
3 | printf("©©%s");
| ^
1 warning generated.
```
https://github.com/llvm/llvm-project/pull/169803
More information about the cfe-commits
mailing list