[clang] [clang][Lex] Replace push_back with emplace_back for vector insertions (PR #232260)

Hardik Kumar via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 22 03:14:10 PDT 2026


================
@@ -737,6 +737,11 @@ class alignas(8) Module {
 
     /// The message provided to the user when there is a conflict.
     std::string Message;
+
+    /// Construct an unresolved conflict.
+    UnresolvedConflict() = default;
+    UnresolvedConflict(ModuleId Id, std::string Message)
+        : Id(Id), Message(Message) {}
----------------
hardikxk wrote:

```
UnresolvedConflict(ModuleId Id, std::string Message)
        : Id(std::move(Id)), Message(std::move(Message)) {}
```
This should move the parameters as expected?

https://github.com/llvm/llvm-project/pull/232260


More information about the cfe-commits mailing list