[clang] [clang] Move the diagnostic of unexpected token after module name from phase 4 to phase 7 (PR #187846)

[LLVM Continuous Integration via cfe-commits]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `llvm-clang-aarch64-darwin` running on `doug-worker-4` while building `clang` at step 6 "test-build-unified-tree-check-all".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/190/builds/48319

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 6 (test-build-unified-tree-check-all) failure: test (failure)
******************** TEST 'Clang :: Modules/GH204633.cppm' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
rm -rf /Volumes/RAMDisk/buildbot-root/aarch64-darwin/build/tools/clang/test/Modules/Output/GH204633.cppm.tmp
# executed command: rm -rf /Volumes/RAMDisk/buildbot-root/aarch64-darwin/build/tools/clang/test/Modules/Output/GH204633.cppm.tmp
# note: command had no output on stdout or stderr
# RUN: at line 2
split-file /Users/buildbot/buildbot-root/llvm-project/clang/test/Modules/GH204633.cppm /Volumes/RAMDisk/buildbot-root/aarch64-darwin/build/tools/clang/test/Modules/Output/GH204633.cppm.tmp
# executed command: split-file /Users/buildbot/buildbot-root/llvm-project/clang/test/Modules/GH204633.cppm /Volumes/RAMDisk/buildbot-root/aarch64-darwin/build/tools/clang/test/Modules/Output/GH204633.cppm.tmp
# note: command had no output on stdout or stderr
# RUN: at line 3
/Volumes/RAMDisk/buildbot-root/aarch64-darwin/build/bin/clang -cc1 -internal-isystem /Volumes/RAMDisk/buildbot-root/aarch64-darwin/build/lib/clang/24/include -nostdsysteminc -std=c++26 -triple x86_64-pc-win32 -fsyntax-only -fmodules    -fimplicit-module-maps -fmodules-cache-path=/Volumes/RAMDisk/buildbot-root/aarch64-darwin/build/tools/clang/test/Modules/Output/GH204633.cppm.tmp    -fmodule-map-file=/Volumes/RAMDisk/buildbot-root/aarch64-darwin/build/tools/clang/test/Modules/Output/GH204633.cppm.tmp/original.cppm -verify /Volumes/RAMDisk/buildbot-root/aarch64-darwin/build/tools/clang/test/Modules/Output/GH204633.cppm.tmp/original.cppm
# executed command: /Volumes/RAMDisk/buildbot-root/aarch64-darwin/build/bin/clang -cc1 -internal-isystem /Volumes/RAMDisk/buildbot-root/aarch64-darwin/build/lib/clang/24/include -nostdsysteminc -std=c++26 -triple x86_64-pc-win32 -fsyntax-only -fmodules -fimplicit-module-maps -fmodules-cache-path=/Volumes/RAMDisk/buildbot-root/aarch64-darwin/build/tools/clang/test/Modules/Output/GH204633.cppm.tmp -fmodule-map-file=/Volumes/RAMDisk/buildbot-root/aarch64-darwin/build/tools/clang/test/Modules/Output/GH204633.cppm.tmp/original.cppm -verify /Volumes/RAMDisk/buildbot-root/aarch64-darwin/build/tools/clang/test/Modules/Output/GH204633.cppm.tmp/original.cppm
# .---command stderr------------
# | error: 'expected-error' diagnostics expected but not seen: 
# |   File /Volumes/RAMDisk/buildbot-root/aarch64-darwin/build/tools/clang/test/Modules/Output/GH204633.cppm.tmp/original.cppm Line 4 (directive at /Volumes/RAMDisk/buildbot-root/aarch64-darwin/build/tools/clang/test/Modules/Output/GH204633.cppm.tmp/original.cppm:1): unexpected preprocessing token '{' after module name
# | error: 'expected-error' diagnostics seen but not expected: 
# |   File /Volumes/RAMDisk/buildbot-root/aarch64-darwin/build/tools/clang/test/Modules/Output/GH204633.cppm.tmp/original.cppm Line 4: unexpected '{' after module name, only ';' and '[' (start of attribute specifier sequence) are allowed
# | 2 errors generated.
# `-----------------------------
# error: command failed with exit status: 1

--

********************


```

</details>

https://github.com/llvm/llvm-project/pull/187846