[clang] [clang] Move the diagnostic of unexpected token after module name from phase 4 to phase 7 (PR #187846)

Fri Aug 21 10:00:25 PDT 2026

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `openmp-offload-amdgpu-runtime-2` running on `rocm-worker-hw-02` while building `clang` at step 3 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/10/builds/34362

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 3 (annotate) failure: 'python ../llvm.src/offload/ci/openmp-offload-amdgpu-libc-runtime.py ...' (failure)
...
PASS: Clang :: Index/complete-objc-message-id.m (16447 of 26124)
PASS: Clang :: Index/complete-objc-message.m (16448 of 26124)
PASS: Clang :: Modules/GH170429.cpp (16449 of 26124)
PASS: Clang :: Modules/GH204632.cppm (16450 of 26124)
PASS: Clang :: Modules/autoload-subdirectory.cpp (16451 of 26124)
PASS: Clang :: Modules/available-is-better.cpp (16452 of 26124)
UNSUPPORTED: Clang :: Modules/compiler_builtins_aarch64.m (16453 of 26124)
UNSUPPORTED: Clang :: Modules/compiler_builtins_arm.m (16454 of 26124)
PASS: Clang :: Modules/align-val-t-merge.cpp (16455 of 26124)
PASS: Clang :: Modules/anon-linkage.cppm (16456 of 26124)
FAIL: Clang :: Modules/GH204633.cppm (16457 of 26124)
******************** TEST 'Clang :: Modules/GH204633.cppm' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
rm -rf /home/botworker/builds/openmp-offload-amdgpu-runtime-2/build/llvm.build/tools/clang/test/Modules/Output/GH204633.cppm.tmp
# executed command: rm -rf /home/botworker/builds/openmp-offload-amdgpu-runtime-2/build/llvm.build/tools/clang/test/Modules/Output/GH204633.cppm.tmp
# note: command had no output on stdout or stderr
# RUN: at line 2
split-file /home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/clang/test/Modules/GH204633.cppm /home/botworker/builds/openmp-offload-amdgpu-runtime-2/build/llvm.build/tools/clang/test/Modules/Output/GH204633.cppm.tmp
# executed command: split-file /home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/clang/test/Modules/GH204633.cppm /home/botworker/builds/openmp-offload-amdgpu-runtime-2/build/llvm.build/tools/clang/test/Modules/Output/GH204633.cppm.tmp
# note: command had no output on stdout or stderr
# RUN: at line 3
/home/botworker/builds/openmp-offload-amdgpu-runtime-2/build/llvm.build/bin/clang -cc1 -internal-isystem /home/botworker/builds/openmp-offload-amdgpu-runtime-2/build/llvm.build/lib/clang/24/include -nostdsysteminc -std=c++26 -triple x86_64-pc-win32 -fsyntax-only -fmodules    -fimplicit-module-maps -fmodules-cache-path=/home/botworker/builds/openmp-offload-amdgpu-runtime-2/build/llvm.build/tools/clang/test/Modules/Output/GH204633.cppm.tmp    -fmodule-map-file=/home/botworker/builds/openmp-offload-amdgpu-runtime-2/build/llvm.build/tools/clang/test/Modules/Output/GH204633.cppm.tmp/original.cppm -verify /home/botworker/builds/openmp-offload-amdgpu-runtime-2/build/llvm.build/tools/clang/test/Modules/Output/GH204633.cppm.tmp/original.cppm
# executed command: /home/botworker/builds/openmp-offload-amdgpu-runtime-2/build/llvm.build/bin/clang -cc1 -internal-isystem /home/botworker/builds/openmp-offload-amdgpu-runtime-2/build/llvm.build/lib/clang/24/include -nostdsysteminc -std=c++26 -triple x86_64-pc-win32 -fsyntax-only -fmodules -fimplicit-module-maps -fmodules-cache-path=/home/botworker/builds/openmp-offload-amdgpu-runtime-2/build/llvm.build/tools/clang/test/Modules/Output/GH204633.cppm.tmp -fmodule-map-file=/home/botworker/builds/openmp-offload-amdgpu-runtime-2/build/llvm.build/tools/clang/test/Modules/Output/GH204633.cppm.tmp/original.cppm -verify /home/botworker/builds/openmp-offload-amdgpu-runtime-2/build/llvm.build/tools/clang/test/Modules/Output/GH204633.cppm.tmp/original.cppm
# .---command stderr------------
# | error: 'expected-error' diagnostics expected but not seen: 
# |   File /home/botworker/builds/openmp-offload-amdgpu-runtime-2/build/llvm.build/tools/clang/test/Modules/Output/GH204633.cppm.tmp/original.cppm Line 4 (directive at /home/botworker/builds/openmp-offload-amdgpu-runtime-2/build/llvm.build/tools/clang/test/Modules/Output/GH204633.cppm.tmp/original.cppm:1): unexpected preprocessing token '{' after module name
# | error: 'expected-error' diagnostics seen but not expected: 
# |   File /home/botworker/builds/openmp-offload-amdgpu-runtime-2/build/llvm.build/tools/clang/test/Modules/Output/GH204633.cppm.tmp/original.cppm Line 4: unexpected '{' after module name, only ';' and '[' (start of attribute specifier sequence) are allowed
# | 2 errors generated.
# `-----------------------------
# error: command failed with exit status: 1

--

********************
PASS: Clang :: Modules/GH207581.cpp (16458 of 26124)
PASS: Clang :: Misc/diag-mapping2.c (16459 of 26124)
PASS: Clang :: Misc/diag-null-bytes-in-line.cpp (16460 of 26124)
PASS: Clang :: Modules/at-import-in-framework-header.m (16461 of 26124)
PASS: Clang :: Modules/attr-unavailable.m (16462 of 26124)
PASS: Clang :: Misc/amdgcn.languageOptsOpenCL.cl (16463 of 26124)
PASS: Clang :: Misc/amdgcn.unsupported_core_3.1.cl (16464 of 26124)
UNSUPPORTED: Clang :: Modules/aarch64-sme-keywords.cppm (16465 of 26124)
PASS: Clang :: Modules/add-remove-private.m (16466 of 26124)
PASS: Clang :: Misc/diag-macro-backtrace2.c (16467 of 26124)
Step 9 (run check-clang) failure: run check-clang (failure)
...
PASS: Clang :: Index/complete-objc-message-id.m (16447 of 26124)
PASS: Clang :: Index/complete-objc-message.m (16448 of 26124)
PASS: Clang :: Modules/GH170429.cpp (16449 of 26124)
PASS: Clang :: Modules/GH204632.cppm (16450 of 26124)
PASS: Clang :: Modules/autoload-subdirectory.cpp (16451 of 26124)
PASS: Clang :: Modules/available-is-better.cpp (16452 of 26124)
UNSUPPORTED: Clang :: Modules/compiler_builtins_aarch64.m (16453 of 26124)
UNSUPPORTED: Clang :: Modules/compiler_builtins_arm.m (16454 of 26124)
PASS: Clang :: Modules/align-val-t-merge.cpp (16455 of 26124)
PASS: Clang :: Modules/anon-linkage.cppm (16456 of 26124)
FAIL: Clang :: Modules/GH204633.cppm (16457 of 26124)
******************** TEST 'Clang :: Modules/GH204633.cppm' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
rm -rf /home/botworker/builds/openmp-offload-amdgpu-runtime-2/build/llvm.build/tools/clang/test/Modules/Output/GH204633.cppm.tmp
# executed command: rm -rf /home/botworker/builds/openmp-offload-amdgpu-runtime-2/build/llvm.build/tools/clang/test/Modules/Output/GH204633.cppm.tmp
# note: command had no output on stdout or stderr
# RUN: at line 2
split-file /home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/clang/test/Modules/GH204633.cppm /home/botworker/builds/openmp-offload-amdgpu-runtime-2/build/llvm.build/tools/clang/test/Modules/Output/GH204633.cppm.tmp
# executed command: split-file /home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/clang/test/Modules/GH204633.cppm /home/botworker/builds/openmp-offload-amdgpu-runtime-2/build/llvm.build/tools/clang/test/Modules/Output/GH204633.cppm.tmp
# note: command had no output on stdout or stderr
# RUN: at line 3
/home/botworker/builds/openmp-offload-amdgpu-runtime-2/build/llvm.build/bin/clang -cc1 -internal-isystem /home/botworker/builds/openmp-offload-amdgpu-runtime-2/build/llvm.build/lib/clang/24/include -nostdsysteminc -std=c++26 -triple x86_64-pc-win32 -fsyntax-only -fmodules    -fimplicit-module-maps -fmodules-cache-path=/home/botworker/builds/openmp-offload-amdgpu-runtime-2/build/llvm.build/tools/clang/test/Modules/Output/GH204633.cppm.tmp    -fmodule-map-file=/home/botworker/builds/openmp-offload-amdgpu-runtime-2/build/llvm.build/tools/clang/test/Modules/Output/GH204633.cppm.tmp/original.cppm -verify /home/botworker/builds/openmp-offload-amdgpu-runtime-2/build/llvm.build/tools/clang/test/Modules/Output/GH204633.cppm.tmp/original.cppm
# executed command: /home/botworker/builds/openmp-offload-amdgpu-runtime-2/build/llvm.build/bin/clang -cc1 -internal-isystem /home/botworker/builds/openmp-offload-amdgpu-runtime-2/build/llvm.build/lib/clang/24/include -nostdsysteminc -std=c++26 -triple x86_64-pc-win32 -fsyntax-only -fmodules -fimplicit-module-maps -fmodules-cache-path=/home/botworker/builds/openmp-offload-amdgpu-runtime-2/build/llvm.build/tools/clang/test/Modules/Output/GH204633.cppm.tmp -fmodule-map-file=/home/botworker/builds/openmp-offload-amdgpu-runtime-2/build/llvm.build/tools/clang/test/Modules/Output/GH204633.cppm.tmp/original.cppm -verify /home/botworker/builds/openmp-offload-amdgpu-runtime-2/build/llvm.build/tools/clang/test/Modules/Output/GH204633.cppm.tmp/original.cppm
# .---command stderr------------
# | error: 'expected-error' diagnostics expected but not seen: 
# |   File /home/botworker/builds/openmp-offload-amdgpu-runtime-2/build/llvm.build/tools/clang/test/Modules/Output/GH204633.cppm.tmp/original.cppm Line 4 (directive at /home/botworker/builds/openmp-offload-amdgpu-runtime-2/build/llvm.build/tools/clang/test/Modules/Output/GH204633.cppm.tmp/original.cppm:1): unexpected preprocessing token '{' after module name
# | error: 'expected-error' diagnostics seen but not expected: 
# |   File /home/botworker/builds/openmp-offload-amdgpu-runtime-2/build/llvm.build/tools/clang/test/Modules/Output/GH204633.cppm.tmp/original.cppm Line 4: unexpected '{' after module name, only ';' and '[' (start of attribute specifier sequence) are allowed
# | 2 errors generated.
# `-----------------------------
# error: command failed with exit status: 1

--

********************
PASS: Clang :: Modules/GH207581.cpp (16458 of 26124)
PASS: Clang :: Misc/diag-mapping2.c (16459 of 26124)
PASS: Clang :: Misc/diag-null-bytes-in-line.cpp (16460 of 26124)
PASS: Clang :: Modules/at-import-in-framework-header.m (16461 of 26124)
PASS: Clang :: Modules/attr-unavailable.m (16462 of 26124)
PASS: Clang :: Misc/amdgcn.languageOptsOpenCL.cl (16463 of 26124)
PASS: Clang :: Misc/amdgcn.unsupported_core_3.1.cl (16464 of 26124)
UNSUPPORTED: Clang :: Modules/aarch64-sme-keywords.cppm (16465 of 26124)
PASS: Clang :: Modules/add-remove-private.m (16466 of 26124)
PASS: Clang :: Misc/diag-macro-backtrace2.c (16467 of 26124)

```

</details>

https://github.com/llvm/llvm-project/pull/187846