[clang] [CIR] Separate floating-point bin ops from integer bin ops (PR #201462)

Andy Kaylor via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 22 09:16:15 PDT 2026


================
@@ -606,17 +606,23 @@ mlir::Value ComplexExprEmitter::emitBinAdd(const BinOpInfo &op) {
       mlir::isa<cir::ComplexType>(op.rhs.getType()))
     return cir::ComplexAddOp::create(builder, op.loc, op.lhs, op.rhs);
 
+  auto createAdd = [&](mlir::Location loc, mlir::Value a, mlir::Value b) {
+    return cir::isFPOrVectorOfFPType(a.getType())
----------------
andykaylor wrote:

We could, but the verifier will also check that. I suppose an assert here would catch it closer to where the error was introduced.

https://github.com/llvm/llvm-project/pull/201462


More information about the cfe-commits mailing list