[clang] [CIR] Separate floating-point bin ops from integer bin ops (PR #201462)
Erich Keane via cfe-commits
cfe-commits at lists.llvm.org
Mon Jun 22 08:08:04 PDT 2026
================
@@ -606,17 +606,23 @@ mlir::Value ComplexExprEmitter::emitBinAdd(const BinOpInfo &op) {
mlir::isa<cir::ComplexType>(op.rhs.getType()))
return cir::ComplexAddOp::create(builder, op.loc, op.lhs, op.rhs);
+ auto createAdd = [&](mlir::Location loc, mlir::Value a, mlir::Value b) {
+ return cir::isFPOrVectorOfFPType(a.getType())
----------------
erichkeane wrote:
Can we add an assert that `b` is the same here too? Perhaps in each of these create functions:
`assert(cir::isFPOrVectorOfFPType(a.getType()) == cir::isFPOrVectorOfFPType(b.getType()))` ?
https://github.com/llvm/llvm-project/pull/201462
More information about the cfe-commits
mailing list