[clang] [clang] Use ClassifyInternal in binary op value kind classification when the binary op is type dependent (PR #202852)

[via cfe-commits]

llvmorg-github-actions[bot] wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-clang

Author: Yihan Wang (yronglin)

<details>
<summary>Changes</summary>

This is a follow up PR for https://github.com/llvm/llvm-project/pull/202696. 

In 202693, we use `ClassifyExprValueKind`,  this PR changed to use `ClassifyInternal`, which is what seems to be used everywhere else.

---
Full diff: https://github.com/llvm/llvm-project/pull/202852.diff


1 Files Affected:

- (modified) clang/lib/AST/ExprClassification.cpp (+1-1) 


``````````diff
diff --git a/clang/lib/AST/ExprClassification.cpp b/clang/lib/AST/ExprClassification.cpp
index d153afda71c4b..0b848d283d763 100644
--- a/clang/lib/AST/ExprClassification.cpp
+++ b/clang/lib/AST/ExprClassification.cpp
@@ -622,7 +622,7 @@ static Cl::Kinds ClassifyBinaryOp(ASTContext &Ctx, const BinaryOperator *E) {
   // expressions can be either lvalues or prvalues depending on whether they
   // might resolve to an overloaded operator.
   if (E->getType() == Ctx.DependentTy)
-    return ClassifyExprValueKind(Ctx.getLangOpts(), E, E->getValueKind());
+    return ClassifyInternal(Ctx, E);
 
   // C++ [expr.ass]p1: All [...] return an lvalue referring to the left operand.
   // Except we override this for writes to ObjC properties.

``````````

</details>


https://github.com/llvm/llvm-project/pull/202852