[clang-tools-extra] [clang-tidy][modernize-use-std-erase] Replace iterator erase-remove idiom with std::(erase/erase_if) (PR #193407)

[Omar Hossam via cfe-commits]

moar55 wrote:

Why is it complaining that std::string doesn't have .end() 🤔 ?
I thought we now have a universal std mock.

https://github.com/llvm/llvm-project/pull/193407