[clang] 79dfa88 - [clang][modules-driver] Add missing PrependArg for Clang module precompile jobs (#191610)
via cfe-commits
cfe-commits at lists.llvm.org
Sat Apr 11 01:28:35 PDT 2026
Author: Naveen Seth Hanig
Date: 2026-04-11T10:28:30+02:00
New Revision: 79dfa887f1b5d3f3418dc8b5aad3c75e9aa1f1ad
URL: https://github.com/llvm/llvm-project/commit/79dfa887f1b5d3f3418dc8b5aad3c75e9aa1f1ad
DIFF: https://github.com/llvm/llvm-project/commit/79dfa887f1b5d3f3418dc8b5aad3c75e9aa1f1ad.diff
LOG: [clang][modules-driver] Add missing PrependArg for Clang module precompile jobs (#191610)
In `createClangModulePrecompileJob`, the `PrependArg` parameter was not
being passed for the newly created Clang module precompile job.
This causes failures for setups where the clang executable is a wrapper
(e.g., the llvm-driver wrapper).
See
https://github.com/llvm/llvm-project/pull/191258#issuecomment-4227294864
Added:
Modified:
clang/lib/Driver/ModulesDriver.cpp
Removed:
################################################################################
diff --git a/clang/lib/Driver/ModulesDriver.cpp b/clang/lib/Driver/ModulesDriver.cpp
index 1a5fcb491c686..82865f903590f 100644
--- a/clang/lib/Driver/ModulesDriver.cpp
+++ b/clang/lib/Driver/ModulesDriver.cpp
@@ -1252,11 +1252,12 @@ createClangModulePrecompileJob(Compilation &C, const Command &ImportingJob,
for (const auto &Arg : BuildArgs)
JobArgs.push_back(TCArgs.MakeArgString(Arg));
- return std::make_unique<Command>(*PA, ImportingJob.getCreator(),
- ResponseFileSupport::AtFileUTF8(),
- C.getDriver().getClangProgramPath(), JobArgs,
- /*Inputs=*/ArrayRef<InputInfo>{},
- /*Outputs=*/ArrayRef<InputInfo>{});
+ const auto &D = C.getDriver();
+ return std::make_unique<Command>(
+ *PA, ImportingJob.getCreator(), ResponseFileSupport::AtFileUTF8(),
+ D.getClangProgramPath(), JobArgs,
+ /*Inputs=*/ArrayRef<InputInfo>{},
+ /*Outputs=*/ArrayRef<InputInfo>{}, D.getPrependArg());
}
/// Creates a \c ClangModuleJobNode with associated job for each unique Clang
More information about the cfe-commits
mailing list