[libunwind] Revert "Silence -Wunused-parameter warnings in Unwind-wasm.c" (PR #175776)
via cfe-commits
cfe-commits at lists.llvm.org
Tue Jan 13 07:14:41 PST 2026
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-libunwind
Author: Sam Clegg (sbc100)
<details>
<summary>Changes</summary>
Reverts llvm/llvm-project#<!-- -->125412
See the discussion in #<!-- -->125412 for why this is necessary. The summary is that:
- Eliding arguments is the C23 extension
- `-Wno-unused-parameter` is part of the build for libunwind, so the codebase does allow them.
---
Full diff: https://github.com/llvm/llvm-project/pull/175776.diff
1 Files Affected:
- (modified) libunwind/src/Unwind-wasm.c (+4-2)
``````````diff
diff --git a/libunwind/src/Unwind-wasm.c b/libunwind/src/Unwind-wasm.c
index b0d6cd2d00fc5..2f4498c3f3989 100644
--- a/libunwind/src/Unwind-wasm.c
+++ b/libunwind/src/Unwind-wasm.c
@@ -102,7 +102,8 @@ _LIBUNWIND_EXPORT uintptr_t _Unwind_GetIP(struct _Unwind_Context *context) {
}
/// Not used in Wasm.
-_LIBUNWIND_EXPORT void _Unwind_SetIP(struct _Unwind_Context *, uintptr_t) {}
+_LIBUNWIND_EXPORT void _Unwind_SetIP(struct _Unwind_Context *context,
+ uintptr_t value) {}
/// Called by personality handler to get LSDA for current frame.
_LIBUNWIND_EXPORT uintptr_t
@@ -114,7 +115,8 @@ _Unwind_GetLanguageSpecificData(struct _Unwind_Context *context) {
}
/// Not used in Wasm.
-_LIBUNWIND_EXPORT uintptr_t _Unwind_GetRegionStart(struct _Unwind_Context *) {
+_LIBUNWIND_EXPORT uintptr_t
+_Unwind_GetRegionStart(struct _Unwind_Context *context) {
return 0;
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/175776
More information about the cfe-commits
mailing list